[Net] Add and document network messages in protocol.h #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids string typos (by making the compiler check)
- Makes it easier to grep for handling/generation of a certain message type
- Refer directly to documentation by following the symbol in IDE
- Move list of valid message types to protocol.cpp:
protocol.cpp is a more appropriate place for this, and having
the array there makes it easier to keep things consistent.
This is being done as a separate commit so as to not trample on the initial cherry-picked commit.
Fuzzbawls
added this to In progress
in Update network code from upstream
via automation
21 tasks
furszy
approved these changes
May 4, 2020
src/main.cpp
Outdated
| sporkManager.ProcessSpork(pfrom, strCommand, vRecv); | ||
| masternodeSync.ProcessMessage(pfrom, strCommand, vRecv); | ||
| bool found = false; | ||
| const std::vector<std::string> &allMessages = getAllNetMessageTypes(); |
There was a problem hiding this comment.
This is only used for the tier two messages check, would be good to call a getAllTierTwoMessageTypes instead. Decreasing the amount of cycles of the loop that is below.
Update network code from upstream
automation
moved this from In progress
to Reviewer approved
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from bitcoin#7181 with layer 2 messages in a followup commit, then ran both commits through
clang-format-diff.py