Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup][GUI] Remove zPIV faqs #1548

Merged
merged 2 commits into from
Jun 4, 2020
Merged

[Cleanup][GUI] Remove zPIV faqs #1548

merged 2 commits into from
Jun 4, 2020

Conversation

random-zebra
Copy link

Closes #1305

@random-zebra random-zebra added GUI Cleanup Trivial extremely simple issues labels Apr 21, 2020
@random-zebra random-zebra added this to the Future milestone Apr 21, 2020
@random-zebra random-zebra self-assigned this Apr 21, 2020
@Fuzzbawls
Copy link
Collaborator

Since we're changing things here, this may be a good opportunity to do away with the ambiguous UI element and function names (ex: pushButtonFaq4, labelContent4, onFaq4Clicked(), etc) and instead give them descriptive names that relate to what section they correspond to.

This will also help in the future if/when new sections are added.

@random-zebra
Copy link
Author

random-zebra commented Apr 22, 2020 •
edited
Loading

Refactored all onFaqClicked functions into a single method taking the widget in question as argument, and addressed @Fuzzbawls 's concern about UI elements names.

@random-zebra random-zebra added NoFunctionalChanges Refactoring and removed Trivial extremely simple issues labels Apr 22, 2020
@random-zebra random-zebra modified the milestones: Future, 5.0.0 Apr 24, 2020
@random-zebra
Copy link
Author

Rebased

furszy
furszy approved these changes Jun 3, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, ACK fc89e23 .

Fuzzbawls
Fuzzbawls approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fc89e23

@Fuzzbawls Fuzzbawls merged commit 176d3ae into PIVX-Project:master Jun 4, 2020
@random-zebra random-zebra deleted the 202004_cleanup_zpiv_faq branch September 24, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

Assignees

@random-zebra random-zebra

Labels
Cleanup GUI NoFunctionalChanges Refactoring
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

[GUI] Remove zPIV FAQ sections.
3 participants
@random-zebra @Fuzzbawls @furszy