Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract out CTransaction-specific signing into SignatureCreator #1564

Merged
merged 1 commit into from
May 20, 2020
Merged

Abstract out CTransaction-specific signing into SignatureCreator #1564

merged 1 commit into from
May 20, 2020

Conversation

furszy
Copy link

@furszy furszy commented Apr 25, 2020

Coming from upstream@5208

Build an abstraction class BaseSignatureCreator that doesn't depend on the data type being signed, and a SignatureCreator specific to CTransaction's. Instead of doing the abstraction at the hash compution level, do it at the signature creation level, which means a slight bit more code duplication, but less code changes.

Full disclosure: this is useful for sidechains-related work.

@furszy furszy self-assigned this Apr 25, 2020
random-zebra
random-zebra previously approved these changes Apr 28, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fd153f2

@random-zebra random-zebra added this to In Progress in perpetual updating PIVX Core to BTC Core via automation Apr 28, 2020
@random-zebra random-zebra added this to the 5.0.0 milestone Apr 28, 2020
Fuzzbawls
Fuzzbawls previously approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

utACK fd153f2

perpetual updating PIVX Core to BTC Core automation moved this from In Progress to Ready May 20, 2020
@Fuzzbawls
Copy link
Collaborator

actually, needs a quick rebase to address a 1 line conflict from #1557.

@furszy
Abstract out Ctransaction-specific signing into TransactionSignatureC…
9033b92 
…reator

Coming from btc@18051c7fbd224e32d9a5fea96f1083210cea3a14
@furszy furszy dismissed stale reviews from Fuzzbawls and random-zebra via 9033b92 May 20, 2020 16:12
perpetual updating PIVX Core to BTC Core automation moved this from Ready to In Progress May 20, 2020
@furszy
Copy link
Author

furszy commented May 20, 2020

Done, rebased.

Fuzzbawls
Fuzzbawls approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9033b92

perpetual updating PIVX Core to BTC Core automation moved this from In Progress to Ready May 20, 2020
random-zebra
random-zebra approved these changes May 20, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9033b92 and merging...

@random-zebra random-zebra merged commit 2c11e37 into PIVX-Project:master May 20, 2020
perpetual updating PIVX Core to BTC Core automation moved this from Ready to Done May 20, 2020
@furszy furszy deleted the 2020_backport_btc_5208 branch November 29, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@furszy furszy

Labels
Refactoring Upstream
Projects
perpetual updating PIVX Core to BTC Core
  
Done
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furszy @Fuzzbawls @random-zebra