[Trivial] Unused Image Removal & Readme Revisions #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old images that are no longer in use from Bitcoin Core, Dash, and old PIVX wallets.
Removing of unused icons in the pivx.qrc and QT makefile
Grammar revisions & added PIVX Discord Link
Removed all unused and unnecessary Bitcoin Core images and icons from previous designers that are no longer a part of the codebase.
Removal of past owners and creators of images and icons that are removed from the codebase.
Further removal of unnecessary and unused code for images & animation.
Removal of unnecessary and unused code for images & animation (movies).
No longer using this animation effect - Removed.
Removal of unused animation (spinning/rotation) effect.
Removal of file folder previously containing old Bitcoin Core rotation/animation effects no longer being used.
Removal of old .bmp files no longer used in the codebase
Updated the current size of the PIVX Blockchain/ required space on a user's device.
There was a problem hiding this comment.
Thanks for the effort @YuurinBee , greatly appreciated.
There's a trailing whitespace which is causing the linter travis script to fail, see inline comment.
random-zebra
added this to In progress
in Community Developer Contributions
via automation
Removing the extra space
My pleasure, offering what I can. Just made the edit! |
Community Developer Contributions
automation
moved this from In progress
to Reviewer approved
May 8, 2020
Community Developer Contributions
automation
moved this from Reviewer approved
to Accepted
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily for the removal of unused icons and images from past builds (Bitcoin Core, Dash, & old PIVX wallets). The icon and image files have been removed, along with their code in pivx.qrc and the qt makefile. Unused animation (spinning/rotating sync) was also removed. All of the artists/designers who contributed icons/images (copyright/attribution) that are no longer in use and relevant have been removed from the documentation.
The final bit is minor grammatical revisions of the PIVX README.md and also added the official PIVX Discord link, next to the Website and Bitcointalk.
*First time modifying code in a qt wallet, just a designer wanting to help optimize.