Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miner] Remove 2017 invalid outputs check #1631

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

furszy
Copy link

@furszy furszy commented May 19, 2020

Small cleanup, removing the zc invalid outputs check from the miner code. (Quickly thinking that we can remove them from everywhere in the sources actually, it's impossible for any of those to get into the current chain. Matter of review each flow properly).

Impossible for any input from 2017 zc exploit to get to the mempool anymore.
Coming from btc@c8b92486c4eca1287546b0683b6af3551db1fe67
@furszy furszy self-assigned this May 19, 2020
@random-zebra random-zebra added this to the 5.0.0 milestone May 19, 2020
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0523da1

@Fuzzbawls Fuzzbawls changed the title Miner: removing 2017 invalid outputs check . [Miner] Remove 2017 invalid outputs check Jun 14, 2020
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0523da1

@furszy furszy merged commit 56b4147 into PIVX-Project:master Jun 15, 2020
@furszy furszy deleted the 2020_miner_minor_cleanup branch November 29, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants