Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Net] Fix masking of irrelevant bits in address groups #1638

Merged
merged 2 commits into from
May 21, 2020
Merged

[Net] Fix masking of irrelevant bits in address groups #1638

merged 2 commits into from
May 21, 2020

Conversation

Fuzzbawls
Copy link
Collaborator

Backport of bitcoin#6556

Original description:

If I'm reading this right, I believe the intent is to keep the high order nBits and mask away the others with 1's. But before this fix it was keeping the high order (8 - nBits). I don't think there was any effect, because the only time this was used was in the case of he.net /36 IPv6 groups so nBits was 4.

@Fuzzbawls Fuzzbawls added this to the 5.0.0 milestone May 21, 2020
@Fuzzbawls Fuzzbawls self-assigned this May 21, 2020
@Fuzzbawls Fuzzbawls mentioned this pull request May 21, 2020
Closed
21 tasks
random-zebra
random-zebra approved these changes May 21, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5d7887e

@furszy furszy added this to Reviewer approved in Update network code from upstream via automation May 21, 2020
furszy
furszy approved these changes May 21, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5d7887e

@furszy furszy merged commit cadf9e6 into PIVX-Project:master May 21, 2020
Update network code from upstream automation moved this from Reviewer approved to Done May 21, 2020
@lyricidal lyricidal mentioned this pull request Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@Fuzzbawls Fuzzbawls

Labels
Bug Network P2P
Projects
No open projects
Update network code from upstream
  
Done
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fuzzbawls @furszy @random-zebra @morcos