[GUI] cs widget: minor usability improvements #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not try to unlock the wallet if either: - cold staking is disabled - the owner or staker address are not valid - the amount is below the minimum allowed - the external delegation warning dialog is not accepted - both addresses are internal
ambassador000
previously approved these changes
May 30, 2020
"Delegating to" instead of "Sending to"
random-zebra
force-pushed
the
202005_GUI_cswidget-ux
branch
from
a1de007
to
ba7a8fd
Compare
furszy
approved these changes
Jun 3, 2020
Fuzzbawls
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three simple fixes to the cold staking widget:
give immediate feedback (with red outline) when the owner address is not valid (same as we have with SendMultiRow objects, e.g. the staker address in this widget). Closes [Feature request] Add warning if invalid address is entered into Owner address field #1596
on send: try to unlock the wallet only when all validity checks are passing.
since the address shown on the confirmation dialog is the staker, change the label "Sending to" in "Delegating to".