Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few compiler warnings fixed. #1659

Merged
merged 1 commit into from
Jun 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6031,7 +6031,7 @@ bool static ProcessMessage(CNode* pfrom, std::string strCommand, CDataStream& vR
} else {
bool found = false;
const std::vector<std::string>& allMessages = getAllNetMessageTypes();
for (const std::string msg : allMessages) {
for (const std::string& msg : allMessages) {
if (msg == strCommand) {
found = true;
break;
Expand Down
4 changes: 2 additions & 2 deletions src/wallet/wallet.h
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ class CReserveKey
typedef std::map<std::string, std::string> mapValue_t;


static void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue)
static inline void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue)
{
if (!mapValue.count("n")) {
nOrderPos = -1; // TODO: calculate elsewhere
Expand All @@ -684,7 +684,7 @@ static void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue)
}


static void WriteOrderPos(const int64_t& nOrderPos, mapValue_t& mapValue)
static inline void WriteOrderPos(const int64_t& nOrderPos, mapValue_t& mapValue)
{
if (nOrderPos == -1)
return;
Expand Down