-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for non-Base58 addresses [Step 2] #1677
Prepare for non-Base58 addresses [Step 2] #1677
Conversation
ad77fdc
to
a10afb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good from visual inspection.
Only the usual minor performance nit about the use of IsValidDestinationString
before DecodeDestination
.
a10afb3
to
422d2d3
Compare
Rebased due conflicts with a recently merged PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 422d2d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 422d2d3
Mixed few things here: