[Trivial] [RPC] Fix listcoldutxos help text #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Jul 20, 2020
| " \"confirmations\" : n (numeric) The number of confirmations of the P2CS utxo\n" | ||
| " \"cold-staker\" : \"address\" (string) The cold-staker address of the P2CS utxo\n" | ||
| " \"coin-owner\" : \"address\" (string) The coin-owner address of the P2CS utxo\n" | ||
| " \"whitelisted\" : \"true\" (boolean) \"true\"/\"false\" coin-owner in delegator whitelist\n" |
There was a problem hiding this comment.
minor nit: true|false instead of only true.
random-zebra
added this to In progress
in Community Developer Contributions
via automation
random-zebra
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Well... guess we can merge this as is for now. utACK 611a30a
Community Developer Contributions
automation
moved this from In progress
to Reviewer approved
Aug 5, 2020
Community Developer Contributions
automation
moved this from Reviewer approved
to Accepted
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the example "Results" in the help command of
listcoldutxoswere misleading, such as "whitelisted" showing as a string instead of a boolean, cold-staker/owner showing as "n", often associated with a numerical value, and "txidn" showing as a "string" even though it's the index number of the UTXO - This PR simply corrects them to what they should be.