forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] 4.2.0 backports #1758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coming from btc@0fd599767d2dabf25ac8c3543cb586cfc4b9d816 Github-Pull: PIVX-Project#1717 Rebased-From: 266b1a0
Coming from btc@bb16c8894becfba8764b13d448ba6e7e7f1608c2 Github-Pull: PIVX-Project#1717 Rebased-From: 49f4124
This removes the fFromLoadWallet flag in AddToWallet. These were already effectively two methods. Coming from btc@00f09c920c2e8906d2260251be6d1d2fa1bbb29d Github-Pull: PIVX-Project#1717 Rebased-From: c3779c5
Github-Pull: PIVX-Project#1717 Rebased-From: aaf063f
… own legacy file method. Github-Pull: PIVX-Project#1733 Rebased-From: 81d2654
Github-Pull: PIVX-Project#1733 Rebased-From: 5e81e5d
Github-Pull: PIVX-Project#1733 Rebased-From: 01aca7c
Github-Pull: PIVX-Project#1733 Rebased-From: bd4c1b1
Github-Pull: PIVX-Project#1736 Rebased-From: cc33f3f
Github-Pull: PIVX-Project#1742 Rebased-From: a3b9d82
Github-Pull: PIVX-Project#1742 Rebased-From: 49a85e4
Github-Pull: PIVX-Project#1741 Rebased-From: aac7df5
Adjust the settingsconsolewidget event filter to explicitely recognize the key combo for clearing the console. Github-Pull: PIVX-Project#1744 Rebased-From: ff9e3d8
Github-Pull: PIVX-Project#1287 Rebased-From: 96a4232
Github-Pull: PIVX-Project#1751 Rebased-From: 5f3bfce
Github-Pull: PIVX-Project#1747 Rebased-From: 866c7d1
-nuparams startup arg added. help message for nuparams startup arg Github-Pull: PIVX-Project#1747 Rebased-From: 2db8a11
UPGRADE_TESTDUMMY needs to be always at the end to be inlined with the networkUpgrades vector position. Github-Pull: PIVX-Project#1747 Rebased-From: 924a27d
Github-Pull: PIVX-Project#1747 Rebased-From: 78d4f3a
Problem: we are still signaling updates from really old transactions from the backend and, at the same time, the GUI is not loading more than 20k transactions into the transactionTableModel. So, old transactions that are not being shown in the GUI deliberately are re appearing due the signaling update process. This commits solves it, not showing transactions that appeared before the first tx time loaded into the model. Ofc this is only applied if the wallet is exceeding the maximum loaded transactions limit in the GUI (20,000 transactions) Github-Pull: PIVX-Project#1749 Rebased-From: b711a7a
random-zebra
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 919e060
Marked as [WIP] as will need to do a final translation PR and add it here |
furszy
added a commit
that referenced
this pull request
Jul 24, 2020
22ba678 [GUI] Update translations from transifex (Fuzzbawls) Pull request description: For inclusion in 4.2.0 #1758 will be updated once this is merged ACKs for top commit: furszy: utACK 22ba678 random-zebra: utACK 22ba678 Tree-SHA512: cf3051e8b40aa53ccc1c73a13574658ca1650cbb7e535bbadf9a13eb708e76e9ccd318df0b6e34e1dac304c52bfc1f5db8fe6a48ecfdba763b341edb6c16e7b0
For inclusion in 4.2.0 Github-Pull: PIVX-Project#1763 Rebased-From: 22ba678
Added #1763, ready for review |
furszy
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK dd22385 , ready for 4.2 :) .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports the following PRs that have been merged since the
4.2
branch-off:#1717
#1733
#1736
#1742
#1741
#1744
#1287
#1751
#1747
#1749
#1763