[wallet] AvailableCoins code readability improved #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_wallet_AvailableCoins_readability
branch
from
9ed4f9f
to
ac19487
Compare
furszy
changed the title
furszy
force-pushed
the
2020_wallet_AvailableCoins_readability
branch
from
ac19487
to
a13c245
Compare
|
rebased after #1759 merge. Ready for review |
Fuzzbawls
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1759 .
Improved code readability of the
CWallet::AvailableCoinsmethod decoupling nested statements and adding comments in between the checks.Plus, removed an unused "add zero value utxo" flag.
An ugly area of the code could get pretty readable with some love.
#1757 is going further on this area with some more improvements.