Improve usage of fee estimation code #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are more useful fee and priority estimation functions. If there is no fee/pri high enough for the target you are aiming for, it will give you the estimate for the lowest target that you can reliably obtain. This is better than defaulting to the minimum. It will also pass back the target for which it returned an answer.
coming from btc@4fe28236c0c16e20ddd539f38fc8d58db5eb83ed
This provides more conservative estimates and reacts more quickly to a backlog. Unfortunately the unit test for fee estimation depends on the success threshold (and the decay) chosen; also modify the unit test for the new default success thresholds.
coming from btc@56106a3300f844afcadf6dce50d5ef1d337f50b9
|
There is currently a failure in the policyestimator unit test at line 194 BOOST_CHECK(mpool.estimatePriority(i) < origPriEst[i-1] - deltaPri);(e.g. see https://travis-ci.com/github/PIVX-Project/PIVX/jobs/368134714) This happens at i=8 and is probably related to a previous known problem: I wouldn't dig too much on the issue though, as the priority estimation is going to be completely removed (bitcoin#7730) For the functional test, as reported in the description of #1641, the I've un-commented it in 245c3df |
random-zebra
added this to In Progress
in perpetual updating PIVX Core to BTC Core
via automation
1 task
This check currently fails. As the whole priority estimation code will be removed soon (PR 1788), let's just skip it for now.
furszy
changed the title
|
Awesome @random-zebra 👌 , removed the WIP tag from the title. And agree on the removal. |
Fuzzbawls
approved these changes
Aug 18, 2020
perpetual updating PIVX Core to BTC Core
automation
moved this from In Progress
to Ready
Aug 18, 2020
random-zebra
added
the
Needs Release Notes
random-zebra
added a commit
that referenced
this pull request
Aug 23, 2020
2da16f7 [Cleanup] Nuke estimate(smart)priority from the RPC interface (random-zebra) 041f62e [Core] Remove priority estimation (random-zebra) Pull request description: Based on top of - [x] #1787 This removes the functionality behind `estimatepriority` and `estimatesmartpriority` (from bitcoin#7730). Instead of just deprecating the relative RPC commands, I think we can outright remove them, as `estimatepriority` was added only in latest minor release (4.2), and `estimatesmartpriority` is introduced in a PR not even merged yet (#1787). ACKs for top commit: Fuzzbawls: utACK 2da16f7 furszy: utACK 2da16f7 Tree-SHA512: 7dc964c7627a08eae349df40f40c49bc85761171d97f3d7a828421f6dc46ca86dc7a410c75bd8025b7a684aa09d215a08ac6ae19b64617adac6365cfaee55afc
Fuzzbawls
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another back port, coming from dashpay#6134 .
TODO: Left to back port smartfees.py.
We need it to be able to move forward in #1726