Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: IsBlockValueValid refactored properly. #1824

Merged
merged 1 commit into from
Sep 6, 2020
Merged

cleanup: IsBlockValueValid refactored properly. #1824

merged 1 commit into from
Sep 6, 2020

Conversation

furszy
Copy link

@furszy furszy commented Aug 28, 2020 •
edited
Loading

Cleaned IsBlockValueValid method to be much more readable, plus removed a not needed chainActive access.

@furszy furszy self-assigned this Aug 28, 2020
random-zebra
random-zebra previously approved these changes Aug 31, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6513fe1

@random-zebra random-zebra added this to the 5.0.0 milestone Aug 31, 2020
Fuzzbawls
Fuzzbawls previously approved these changes Sep 6, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6513fe1

@random-zebra
Copy link

Needs rebase

@furszy furszy dismissed stale reviews from Fuzzbawls and random-zebra via ed117ab September 6, 2020 16:51
@furszy furszy force-pushed the 2020_getBlockValueValid_cleanup branch from 6513fe1 to ed117ab Compare September 6, 2020 16:51
@furszy
Copy link
Author

furszy commented Sep 6, 2020

rebased

random-zebra
random-zebra approved these changes Sep 6, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK ed117ab and merging...

@random-zebra random-zebra merged commit 6ec609f into PIVX-Project:master Sep 6, 2020
@random-zebra random-zebra modified the milestones: 5.0.0, 4.3.0 Sep 10, 2020
@furszy furszy deleted the 2020_getBlockValueValid_cleanup branch November 29, 2022 14:21
@lyricidal lyricidal mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-zebra random-zebra random-zebra approved these changes

@Fuzzbawls Fuzzbawls Fuzzbawls left review comments

Assignees

@furszy furszy

Labels
Cleanup Masternode
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furszy @random-zebra @Fuzzbawls