Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial][GUI] Fix init messages #1863

Merged

Conversation

random-zebra
Copy link

After #1801 the coins database is updated to the new format.
During this time (which could take a minute or so), QT wallet reports "Loading block index..."

which is wrong: even without the coins DB upgrade, it loads first the sporks DB, before the block index.

So:

  • remove the misplaced init message for BlockIndex load (there's another one in the right place).
  • add a new init message for the coins DB upgrade (if the DB is already upgraded, the function returns immediately so this is shown only for a fraction of a second before "Loading sporks...").

Note: As 4.3 is the first release including the new DB, we should probably backport this trivial PR.

- add "Upgrading coins database..." feedback
- remove misplaced "Loading block index..."
@random-zebra random-zebra added GUI UTXO DBs and Indexes Needs Backport Placeholder tag for anything needing a backport to prior version branches Trivial extremely simple issues labels Sep 23, 2020
@random-zebra random-zebra added this to the 5.0.0 milestone Sep 23, 2020
@random-zebra random-zebra self-assigned this Sep 23, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 979cb74

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 979cb74

@furszy furszy merged commit ad15bce into PIVX-Project:master Sep 23, 2020
furszy added a commit that referenced this pull request Sep 24, 2020
2d10e2e [Trivial][UI] Fix init messages (random-zebra)
3e8ccf0 missing mnping category added to logcategories (furszy)
f182bc8 [Cleanup] emplace CRecipient + remove extra hashing of budget objects (random-zebra)
6204902 [Refactor] Unify GetBudgetSystemCollTX and GetBudgetFinalizationCollTX (random-zebra)
8398b2e [BUG] Duplicated ReserveKey in CBudgetManager::SubmitFinalBudget() (random-zebra)
9c0d4b1 Remove unused mapRequest tracking. (furszy)
a7b3b4f miner: removing a not needed block requests tracking. (furszy)
921fc4b GUI: removing unused TransactionDesc file (static toHTML function is not being called anymore). (furszy)
d956349 GUI: transactionTablemodel, remove unused LongDescriptionRole. (furszy)

Pull request description:

  Simple back porting PR to 4.3 branch, including:

  #1853
  #1855
  #1860
  #1863

ACKs for top commit:
  random-zebra:
    utACK 2d10e2e
  Fuzzbawls:
    utACK 2d10e2e

Tree-SHA512: b23eabfc1ba1c2896782fe77b25d8edad2e0ec6dc0f3a9e78add257e4cf801605bf0f1943690bc04f70587b6d9a8d179770dd312eec40bbfa605bb3caf20cc05
@Fuzzbawls Fuzzbawls modified the milestones: 5.0.0, 4.3.0 Sep 25, 2020
@Fuzzbawls Fuzzbawls removed the Needs Backport Placeholder tag for anything needing a backport to prior version branches label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants