[Wallet] Kill Accounts #1911
Merged
[Wallet] Kill Accounts #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wallet/rpcwallet.cpp
Outdated
| " \"amount\": x.xxx, (numeric) The amount in PIV. This is negative for the 'send' category, and for the\n" | ||
| " 'move' category for moves outbound. It is positive for the 'receive' category,\n" | ||
| " and for the 'move' category for inbound funds.\n" | ||
| " \"category\":\"send|receive\", (string) The transaction category.\n" |
There was a problem hiding this comment.
There are actually other possible categories (orphan, immature, generate).
We, also, probably want to remove the mention to the move category in the previous field (address), now that "accounting entries" are a thing of the past.
This finally removes the last remnants of the account API, which was deprecated in v4.2.0 in favor of a new label API. Up until this commit, it was possible to still use the old account API by starting the wallet with `-deprecatedrpc=account`, but this functionality is now removed.
Fuzzbawls
force-pushed
the
2020_kill-accounts
branch
from
9811f08
to
c6634c0
Compare
furszy
approved these changes
Oct 12, 2020
| if (involvesWatchonly || (::IsMine(*pwalletMain, r.destination) & ISMINE_WATCH_ONLY)) | ||
| entry.pushKV("involvesWatchonly", true); | ||
| MaybePushAddress(entry, r.destination); | ||
| if (wtx.IsCoinBase()) { |
There was a problem hiding this comment.
Not for this PR but this should be if (wtx.IsCoinBase() || wtx.IsCoinstake()) {
Fuzzbawls
added
the
Needs Release Notes
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally removes the last remnants of the account API, which was
deprecated in v4.2.0 in favor of a new label API.
Up until this commit, it was possible to still use the old account API
by starting the wallet with
-deprecatedrpc=account, but thisfunctionality is now removed.
Closes #1706