[Validation] Sapling nullifiers mempool connection #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202011_mempool-nullifiers
branch
from
32bb204
to
93e308e
Compare
|
Rebased. |
|
Nits addressed. |
Also calculate nullifiers map in the dynamic memory usage
are unspent in the coins view cache
random-zebra
force-pushed
the
202011_mempool-nullifiers
branch
from
b0de178
to
7e2d5a6
Compare
2 tasks
Fuzzbawls
approved these changes
Nov 12, 2020
furszy
approved these changes
Nov 12, 2020
Fuzzbawls
added a commit
that referenced
this pull request
Nov 15, 2020
…chor 60ea1d8 [CI][Tests] Move sapling functional tests to their own list (random-zebra) 03aec32 [Tests] Add sapling_mempool to test_runner and re-sort the list (random-zebra) c3a1fff [Test] Add sapling_mempool functional test (random-zebra) 101978d [RPC] Introduce getbestsaplinganchor to get the most recent sapling root (random-zebra) Pull request description: Based on top of: - [x] #1958 - [x] #1964 This adds a functional test to check the bahavior of sapling transactions with the mempool. Specifically, it verifies the nullifiers/anchor management introduced in #1958: - If a transaction spends a sapling note, already spent by another in-mempool transaction, it's not accepted in the mempool. - Same if it tries to double-spend a note already spent on chain. - If, after disconnecting a block, the sapling merkle tree root changes, any transaction that spends a note referencing the old root must be evicted from the mempool. In order to verify the last point, a simple RPC `getbestsaplinganchor` is introduced in the "blockchain" category. It returns the `pcoinsTip` best anchor. Note: without 1958, the test crashes the node, as two transactions spending the same note can both enter the mempool, but then the assertions in the memory pool consistency checks fail during block creation. ACKs for top commit: furszy: Pretty nice!, code review ACK 60ea1d8 Fuzzbawls: utACK 60ea1d8 Tree-SHA512: c321d7866bec56fca31d48286ac28ae44f27c48232919fd3f66fcc858a558b17cc0580163790c74290f376049fa44391a1033eb582ff9716b502673f535048d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of nullifiers of notes spent by mempool transactions (preventing in-mempool double spends).
Add consistency checks with coins view nullifiers.
Also, if the sapling anchor changes after a disconnection, we must evict from mempool any transaction that spends from the now-invalid root.
Built on top of: