Sapling operation new spend from several different sources feature + send/build decoupling. #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serveKey argument. Pass CReserveKey pointer instead of referece to CommitTransaction.
Sapling operation: manage tkeychange better.
…allet and not only using the addressFrom filter.
First step towards cleanup the DecodePaymentAddress unneeded abstraction.
…al SaplingPaymentAddress.
furszy
force-pushed
the
2020_sapling_operation_from_differet_sources
branch
from
8d048ab
to
9639f8b
Compare
|
Updated per zebra's feedback 👍 |
1 task
Fuzzbawls
approved these changes
Nov 12, 2020
furszy
added a commit
that referenced
this pull request
Nov 14, 2020
…lded_sendmany 634ddbf [Tests][Refactor] Check mempool in sapling_wallet.py (random-zebra) 0673634 [Tests] Add test for raw_shielded_sendmany (random-zebra) 07b666c [RPC] Introduce raw_shielded_sendmany (random-zebra) 30f3a09 [Refactoring] Remove testMode from SaplingOperation (random-zebra) 4b0fd27 [Test] shielded_sendmany: check from_transparent argument in unit test (random-zebra) b8e28f8 [Test] Verify shielded_sendmany with generic fromAddress (random-zebra) 4241fbf [RPC] Add option to send from multiple addresses in shielded_sendmany (random-zebra) 60b7c9b [Trivial][RPC] Fix default fee in shielded_sendmany help (random-zebra) 952555f [Refactor] Introduce CreateShieldedTransaction auxiliary fun for RPC (random-zebra) Pull request description: Add the option to `shielded_sendmany` to automatically select the inputs from any transparent or sapling address (inserting the string `"from_transparent"`/`"from_shielded"` instead of the from-address) Create new rpc `raw_shielded_sendmany` which creates (without committing) the shielded transaction and returns a json object. Update the functional tests. Based on top of: - [x] #1961 Starts with `[Refactor] Introduce CreateShieldedTransaction auxiliary fun for RPC` (e014ff3) ACKs for top commit: furszy: ACK 634ddbf and merging.. Tree-SHA512: cd4c3226a1782b86af9bd7915cd75decc94601962c2c40884381118f302bbe35ed2cfefc59962f40e05f5b858b57588edc3cfad7098b13ffbe30e203d801c39f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the sapling operation flow (shielded transaction building) only was allowing to create a transaction from a single address source (transparent or shielded). This means that the user needed to select from which address the wallet should take funds from to spend.
This PR introduces two main new features and several improvements over the sapling operation class.
Main features:
(1) spending from several transparent sources and (2) spending from several shielded sources. Both selected by the operation process automatically, no user input needed.
Secondary improvements:
(1) making the change address key optional, (2) decoupling sapling operation build and send process (this is needed in order to be able to create the tx on the GUI and raw shielded txs using the command line).
Refactoring:
(1)
GetFilteredNotesSaplingPaymentAddress argument moved to optional so it can be omitted in the shielded funds selection process.