Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Reduce number of concurrent jobs #2021

Merged
merged 1 commit into from Dec 5, 2020

Conversation

Fuzzbawls
Copy link
Collaborator

Now that we can run the functional test suite with "--all", we don't
need to have 3 separate jobs to get full test coverage.

@Fuzzbawls Fuzzbawls added this to the 5.0.0 milestone Dec 3, 2020
@Fuzzbawls Fuzzbawls self-assigned this Dec 3, 2020
@random-zebra
Copy link

We should probably keep the --legacywallet separate job though.

@Fuzzbawls
Copy link
Collaborator Author

We should probably keep the --legacywallet separate job though.

hmm...at what point do we ditch that and no longer allow the creation of a pre-HD wallet?

@random-zebra
Copy link

We should probably keep the --legacywallet separate job though.

hmm...at what point do we ditch that and no longer allow the creation of a pre-HD wallet?

I would say after 5.0

Now that we can run the functional test suite with "--all", we don't
need to have 3 separate jobs to get full test coverage.
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e48924f

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e48924f

@furszy furszy merged commit 3845c18 into PIVX-Project:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants