[Sapling] Try to recover corruption of notes cache during send operation #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202011_null-nullifiers
branch
from
bb35d0a
to
7e99d38
Compare
furszy
reviewed
Dec 4, 2020
|
Locks updated. |
random-zebra
force-pushed
the
202011_null-nullifiers
branch
from
7e99d38
to
0dc0896
Compare
also notify the UI so it's updated live.
furszy
reviewed
Dec 5, 2020
There was a problem hiding this comment.
Have tested it with the corrupted wallet and all went well but have to say haven't seen any message of the added logging which is weird.
But well, it's an edge case scenario that we should discover the issue soon anyway (in testnet).
All good for me to go ahead with this one.
Fuzzbawls
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a contingency plan, in case of missing cached nullifier of a spent note in the wallet.
Since, during the spend, the wallet is unlocked, and we have the spending key, we can directly recover the nullifier from the note (provided that we have a valid cached witness) and fix the issue in the background, without requiring any user intervention.
If we don't have the witness, we can still provide a better log and error message in the gui, than a generic, and probably obscure