-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI][BugFix] Duplicate transaction records. #2096
[GUI][BugFix] Duplicate transaction records. #2096
Conversation
643d712
to
f54c206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not fixing the duplicate/triplicate records for send-to-self txes on my big testnet wallet (which I think is due more to the update signal, and might be fixed moving on with the validation interface upgrade).
Nevertheless, this is a good catch, ACK f54c206, with a non-blocking nit/question.
k, then we have one more double records issue to find (at this rhythm post-v5 will be). This double records bug can be replicated creating a proposal, the proposal fee transaction output is being presented twice. Extra info: if you test it with #2100 on top, you will see the proposal name presented properly as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f54c206
Github-Pull: PIVX-Project#2096 Rebased-From: f54c206
41abf5a clear StakeableCoins before initializing (PeterL73) 3de9861 [Policy] Set DEFAULT_SHIELDEDTXFEE_K to 100 (from 1000) (random-zebra) 4a8e571 [BUG] Fix total budget on testnet (random-zebra) 4285bee scripted-diff: Fix "alloted" typo (random-zebra) 107529b Tests: check getbudgetinfo / getbudgetprojection updated output (random-zebra) 495c546 Tests: check invalid RPC inputs in rpc_budget test (random-zebra) 723a41b Consensus: enforce that proposal BlockStart must be a superblock (random-zebra) 5fb488a Consensus: enforce proposal max payments (6 main-net / 20 test-net) (random-zebra) 6377883 [BUG][Tests] Fix remote nodes switched ports in PivxTier2TestFramework (random-zebra) 73864a0 Startup: move masternode port validation inside `initMasternode`. (furszy) 18e83cf Only return the tx hex string in rawdelegatestake (Fuzzbawls) 85d83b1 Further RPC help output cleanups (Fuzzbawls) 2c315a3 Only Return the transaction hex string in `rawshieldsendmany` (Fuzzbawls) a6b3f77 [BUG][GUI] Cache unconfirmed_balance only for transparent outs (random-zebra) d95f0ca [BUG][GUI] Don't return StakingOnlyUnlocked from WalletModel::sendCoins (random-zebra) f17aabc [Trivial][GUI] coin control: Fixed column size in list-mode (random-zebra) f3662f8 [GUI] Finally, fix duplicate records. (furszy) 1d95c40 [DOC] main readme, added latest release version and release date badges (furszy) afcba75 [DOC] main readme, re-written to current project state. (furszy) 7fd9e62 [DOC] Readme, migrated staled travis badge for github actions status badge. (furszy) 227161b [Trivial][RPC] Drop 'ed' suffix from Shielded in TxSaplingToJSON (random-zebra) ed8999a [GUI] send screen, hide shield all coins btn for now. (furszy) Pull request description: further backports for the 5.0 branch: #2094 #2093 #2095 #2096 #2098 #2104 #2102 #2097 #2103 #2101 #2108 #2109 ACKs for top commit: furszy: utACK 41abf5a random-zebra: utACK 41abf5a and merging... Tree-SHA512: 34619594f6e87362f8760a24c39ef25e8acf856de258d1e40f5a1264381fb9e6f6210bcca2b1bc765a0366c7a4467d43c95147bf75f7c2d64d16ee3b41a9efb9
Finally found it, fixing the duplicate record issue.
Briefly explained: As is now,
decomposeDebitTransaction
can return false even when the outputs parsing was done correctly due the non-existency of shielded outputs. If this happens, the callerdecomposeTransaction
process it as ifdecomposeDebitTransaction
didnt parse it successfully, appending an extra all-in-one record.