Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Masternode] Manage status cleanup #2135

Merged
merged 2 commits into from Feb 3, 2021

Conversation

furszy
Copy link

@furszy furszy commented Jan 12, 2021

Focused on two changes inside the active masternode state manager function:

  1. Removed a redundant MN address parsing and port validation (both are covered at startup inside initMasternode).
  2. Modified the inbound connection availability test to not add the self-connection to the connection manager peers vector (as it makes no sense to have it, nor maintain it). This change fixes the scenario in which the node connection already exists locally and the node invalidly logs the "Could not connect to xxx". Plus, changed the logging in the area to be more understandable as well.

…t validation.

Both are covered at startup by `initMasternode`
@furszy furszy self-assigned this Jan 12, 2021
@random-zebra random-zebra added this to the 5.1.0 milestone Jan 17, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 264aba8

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 264aba8

@furszy furszy merged commit 99af033 into PIVX-Project:master Feb 3, 2021
@furszy furszy deleted the 2020_activemasternode branch November 29, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants