[Refactoring] Sapling classes - initialize fields and pass parameters by reference #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
reviewed
Feb 4, 2021
random-zebra
force-pushed
the
202102_sapling-uninitialized-var
branch
from
529d803
to
09fe747
Compare
furszy
approved these changes
Feb 6, 2021
Fuzzbawls
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three minor issues with sapling notes and txes:
Note: these were reported by Synopsys Coverity® (more to come). The
cov-intfolder is added to .gitignore, so the tool can be run directly on the cloned repository, without the risk of staging its files.