Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Depends] Bump Rust to v1.54.0 #2583

Merged

Conversation

Fuzzbawls
Copy link
Collaborator

Bumps our Rust toolchain dependency to a more recent version (1.54.0), which contains Tier 2 support for aarch64-apple targets as well as fixes a bug with windows library file extensions when compiling with mingw.

We still need to use our own custom compiled toolchain to avoid breaking the minimum ABI compatibility for linux builds.

@Fuzzbawls Fuzzbawls added this to the 5.4.0 milestone Oct 3, 2021
@Fuzzbawls Fuzzbawls self-assigned this Oct 3, 2021
@Fuzzbawls Fuzzbawls added this to Review in progress in Apple M1 CPU Compatibility Oct 3, 2021
furszy added a commit that referenced this pull request Oct 10, 2021
ec2d592 [Depends] Remove unused cargo-checksum.sh script (Fuzzbawls)

Pull request description:

  This script became un-necessary with #2280, but the script file and it's
   reference in the Makefile weren't removed.

  Extracted from #2583 as this is a trivial change that is otherwise holding up a follow-up
  linting update and doesn't necessarily need to be included in #2583

ACKs for top commit:
  furszy:
    ACK ec2d592
  random-zebra:
    utACK ec2d592

Tree-SHA512: f2754d4c05fd3274f3b0431a7804f40fc3c45ad21eeedc9e6521068ee5125ba92688131b9723b9cf9a833341d2be0277f8acb0fb9ede77c372c357df4c2780aa
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitian went well, ACK 018c41b

Linux
366fa57ff75b56986e89671051a7530b467f4175febbb0de851457caeacdc813  pivx-5.3.99-aarch64-linux-gnu.tar.gz
10cb97e3a4b75da4f7f85587cf425b55010acff5efa4778e17960a60266e14b6  pivx-5.3.99-arm-linux-gnueabihf.tar.gz
6e7ffd44a3ce234ebc63c8b0ed277cba614a7295972843e4d2461ce65d867095  pivx-5.3.99-i686-pc-linux-gnu.tar.gz
313b0ca21903a23d287ec44233b6e6782da3c37aa211609a5824b759a33fefdd  pivx-5.3.99-x86_64-linux-gnu.tar.gz
8e76ce14344cfcc4c8c28fe6137a847a566eaaee56089d59958d0b984a2bc5e4  src/pivx-5.3.99.tar.gz
fba51e17672d3bdbcd81625032160e6b30565e044dbaf67005f9cbbfebde8234  pivx-linux-5.3-res.yml
Windows
893d677c7113f74b6ece68eb49b2d5c417f452417346414159dea5f56b921f98  pivx-5.3.99-win-unsigned.tar.gz
597dc6850d9c9c55bbbbf4afcc5af17937d6360738be31caa4432950d140def5  pivx-5.3.99-win64-setup-unsigned.exe
e046610310a4145515f9fbf03144fdc42fe70e274258436a50780a1c3d768b50  pivx-5.3.99-win64.zip
ddff3e133322c85f444710a4d3c35118a17ec27dfc6b82a4e58d8658a39c4994  src/pivx-5.3.99.tar.gz
444e014f749d080a40ec5fe6ad5dd59af785366b2e141329809a9e2f56186258  pivx-win-5.3-res.yml
MacOS
16a827cbaa2614c29c27c1e7dccb466f8fc8416aa4e3a8e2fc608092d17dd200  pivx-5.3.99-osx-unsigned.dmg
d9f133127cc569103caab8a4df9f8065475788325152823d50c96054705ac35d  pivx-5.3.99-osx-unsigned.tar.gz
84c34a40c20d1bc4e6abc157e92fac59996cba53e7ee6017b73265fd621525cd  pivx-5.3.99-osx64.tar.gz
a43ed271c907a86ce6db050bf29e02470528e2734e65007fc6b08186bea7ec30  src/pivx-5.3.99.tar.gz
8ff7558e05e4ef65bb22b96c8111772433aac6c1f1584c35ec864024f81d333c  pivx-osx-5.3-res.yml

Apple M1 CPU Compatibility automation moved this from Review in progress to Reviewer approved Oct 18, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 018c41b

@random-zebra random-zebra merged commit 36fe6d3 into PIVX-Project:master Oct 18, 2021
Apple M1 CPU Compatibility automation moved this from Reviewer approved to Done Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants