Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PID file error and datadir handling #2726

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Improve PID file error and datadir handling #2726

merged 5 commits into from
Jan 20, 2022

Conversation

furszy
Copy link

@furszy furszy commented Jan 17, 2022

furszy and others added 5 commits January 16, 2022 21:19
@furszy
Make PID file creating errors fatal
3303376 
Adaptation of btc@561e375c73a37934fe77a519762d81edf7a3325c and btc@3782075a5fd4ad0c15a6119e8cdaf136898f679e
@hebasto @furszy
Add CheckDataDirOption() function
2862a75
@hebasto @furszy
Fix datadir handling in pivxd
aa397eb 
This prevents premature tries to access or create the default datadir.
This is useful when the -datadir option is specified and the default
datadir is unreachable.
@hebasto @furszy
Fix datadir handling in pivx-qt
8fbbd16 
This prevents premature tries to access or create the default datadir.
This is useful when the -datadir option is specified and the default
datadir is unreachable.
@hebasto @furszy
Fix datadir handling in pivx-cli
6358d70 
This prevents premature tries to access or create the default datadir.
This is useful when the -datadir option is specified and the default
datadir is unreachable.
@furszy furszy self-assigned this Jan 17, 2022
Fuzzbawls
Fuzzbawls approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6358d70

random-zebra
random-zebra approved these changes Jan 20, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6358d70

@furszy furszy merged commit 7b265f2 into PIVX-Project:master Jan 20, 2022
@random-zebra random-zebra added this to In Progress in perpetual updating PIVX Core to BTC Core via automation Jan 31, 2022
@random-zebra random-zebra added this to the 6.0.0 milestone Jan 31, 2022
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@furszy furszy

Labels
Upstream Util / log / libs
Projects
perpetual updating PIVX Core to BTC Core
  
In Progress
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@furszy @Fuzzbawls @random-zebra @hebasto