[DMNs] Implement lru cache #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
reviewed
Sep 9, 2023
Liquid369
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
tACK d0e449e
Looks good in comparison to upstream, we can potentially update this a bit more later in seeing how the vector handles the sorting by access time if it becomes an area for some perf improvements, we can look at adjusting it later after seeing how it does
Fuzzbawls
approved these changes
Sep 16, 2023
Liquid369
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A LRU cache is an (unordered) map where, once it is full, the least recently used element is removed.
This PR adds a LRU cache that maps
quorumHash->boolwhereboolistrueiff the quorum has been mined on chain.It is a big optimization compared to checking the database each time