[Bug] Fix data race #2919
Merged
[Bug] Fix data race #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
approved these changes
Mar 27, 2024
Liquid369
approved these changes
Mar 27, 2024
Fuzzbawls
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the data race in which a thread is trying to write
pcoinsTip.cacheSaplingAnchors:CWallet::BlockConnected -> pcoinsTip->GetSaplingAnchorAt(...)At the same time another thread is trying to read
pcoinsTip.cacheSaplingAnchors:ActivateBestChain -> FlushStateToDisk -> pcoinsTip->DynamicMemoryUsage().The fix is trivial
CWallet::BlockConnectedwas not locking the mutexcs_mainthat guardspcoinsTip.This data race was causing the functional test
wallet_basic.pyto randomly fail: To see this I created two test branches where I ranwallet_basic.py50 times in parallel. One branch has this fix the other doesn't.The github action for the branch without this fix failed many times
https://github.com/panleone/PIVX/actions/runs/8428460478
The github action for the branch with this fixed always passed instead
https://github.com/panleone/PIVX/actions/runs/8428472901