Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dash llmq backports #2921

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Dash llmq backports #2921

wants to merge 9 commits into from
+239 −160

Commits on Apr 7, 2024

  1. Fix cleanup of old recovered sigs 

    When iterating the db, we should also include entries that match exactly
the end time.
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    be1c4a7 View commit details
    Browse the repository at this point in the history

  2. Reserve 4k of buffer for CSerializedNetMsg buffer 

    Profiling has shown that a lot of time is spent in resizing the data
vector when large messages are involved.
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    04b6a67 View commit details
    Browse the repository at this point in the history

  3. Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height

    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    7bca9a2 View commit details
    Browse the repository at this point in the history

  4. Introduce startBlockHeight to make things more explicit

    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    fdba615 View commit details
    Browse the repository at this point in the history

  5. CLLMQUtils::IsQuorumActive() shouldn't require cs_main to be held

    @UdjinM6 @panleone
    UdjinM6 authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    bff6e6e View commit details
    Browse the repository at this point in the history

  6. Use CBLSLazySignature in CBatchedSigShares 

    This removes the burden on the message handler thread when many sig batches
arrive. The expensive part of deserialization is now performed in the sig
shares worker thread.

This also removes the need for the specialized deserialization of the sig
shares which tried to avoid the malleability check, as CBLSLazySignature does
not perform malleability checks at all.
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6c63a77 View commit details
    Browse the repository at this point in the history

  7. Implement caching in CRecoveredSigsDb 

    To avoid repeated calls into LevelDB
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    40a247d View commit details
    Browse the repository at this point in the history

  8. Don't sleep in WorkThreadMain when CPU intensive work was done 

    When the current iteration resulted in CPU intensive work, it's likely that
the next iteration will result in work as well. Do not sleep in that case,
as we're otherwise wasting (unused) CPU resources.
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    1bd0c2f View commit details
    Browse the repository at this point in the history

  9. No matter how fast we process sig shares, always force 100ms between … 

    …sending
    @codablock @panleone
    codablock authored and panleone committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    22efef0 View commit details
    Browse the repository at this point in the history