[Main] Don't limit zPIV spends from getting into the mempool #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zPIV spends have no fee associated with them (fees are paid up front during the minting process), the built in rate limiter for zero-fee transactions was kicking in when it shouldn't have. This change will allow zPIV spends in `AcceptToMemoryPool()` and `AcceptableInputs()` to bypass the zero-fee rate limiter. At the same time, also double the default number of bytes to allow per minute before rate limiting. Previous default equated to 15000 bytes per minute, new default is 30000 bytes per minute (exclusive of zPIV spends).
|
utACK |
|
utACK and merging... |
Mrs-X
added a commit
that referenced
this pull request
Oct 28, 2017
1387fbd [Main] Don't limit zPIV spends from getting into the mempool (Fuzzbawls) Tree-SHA512: 92ad0dce5ce033adbc5b32d3949b2e2557821c175068e6483dbc6fabcd5747875550d7f7c49ed4df77a3dc2f0b65f287578d4be112d643921d183c28af0aca07
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Oct 29, 2017
Since zPIV spends have no fee associated with them (fees are paid up front during the minting process), the built in rate limiter for zero-fee transactions was kicking in when it shouldn't have. This change will allow zPIV spends in `AcceptToMemoryPool()` and `AcceptableInputs()` to bypass the zero-fee rate limiter. At the same time, also double the default number of bytes to allow per minute before rate limiting. Previous default equated to 15000 bytes per minute, new default is 30000 bytes per minute (exclusive of zPIV spends). Github-Pull: PIVX-Project#327 Rebased-From: 1387fbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since zPIV spends have no fee associated with them (fees are paid up
front during the minting process), the built in rate limiter for
zero-fee transactions was kicking in when it shouldn't have.
This change will allow zPIV spends in
AcceptToMemoryPool()andAcceptableInputs()to bypass the zero-fee rate limiter.At the same time, also double the default number of bytes to allow per
minute before rate limiting. Previous default equated to 15000 bytes per
minute, new default is 30000 bytes per minute (exclusive of zPIV
spends).