Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Add blocksizenotify command #524

Merged
merged 2 commits into from Feb 2, 2018
Merged

[RPC] Add blocksizenotify command #524

merged 2 commits into from Feb 2, 2018

Conversation

blondfrogs
Copy link

Added a command that will trigger a script when blocks are received that are over a certain size (1MB)

This is being used in conjunction with the fixes to zPIV by @presstab to find out if someone is trying to double spend a zPIV serial, as when a malicious user would do so they would have to flood the blocks with zPIV transactions escalating the block size.

@blondfrogs blondfrogs added the zPiv label Feb 1, 2018
@blondfrogs blondfrogs self-assigned this Feb 1, 2018
@ghost ghost added the review label Feb 1, 2018
@presstab
Copy link

presstab commented Feb 1, 2018

Not really about double spending, more about monitoring for a spam attack.

@Mrs-X
Copy link

Mrs-X commented Feb 1, 2018

utACK with a Nit:

https://github.com/blondfrogs/PIVX/blob/adce95ea5c6cbbe61883b2842e07f7ae7034f6fe/src/main.cpp#L4120

There's static const unsigned int MAX_BLOCK_SIZE_LEGACY = 1000000; in primitves/block.h for this.

@blondfrogs
Copy link
Author

@Mrs-X Removed the magic number

@s3v3nh4cks
Copy link

utACK

@presstab
Copy link

presstab commented Feb 2, 2018

ACK. Thanks for throwing this together @blondfrogs

@Fuzzbawls
Copy link
Collaborator

utACK 44e4d2e

@Mrs-X
Copy link

Mrs-X commented Feb 2, 2018

utACK 44e4d2e and merging...

Edit: had to resolve a merging conflict, so for the records: utACK 8a860eb

@ghost ghost assigned Mrs-X Feb 2, 2018
@Mrs-X Mrs-X merged commit 8a860eb into PIVX-Project:master Feb 2, 2018
Mrs-X added a commit that referenced this pull request Feb 2, 2018
44e4d2e Add blocksizenotify command (Jeremy)

Tree-SHA512: 0deb5a883c5d52d0b4e4681fd5ea6c845363ede4299bb59f10a22b23f00aff4e5bb62a7954b752d7d33db5a422ec169f60360868296aa833849cc3e35145250b
@ghost ghost removed the review label Feb 2, 2018
@Fuzzbawls Fuzzbawls added this to the 3.1.0 milestone Feb 6, 2018
@Fuzzbawls Fuzzbawls added the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Feb 24, 2018
@Fuzzbawls Fuzzbawls changed the title Add blocksizenotify command [RPC] Add blocksizenotify command Apr 30, 2018
@Fuzzbawls Fuzzbawls removed the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants