[RPC] add 'getblockindexstats' function #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK Would love to see this covered in a functional test and possibly brought over to the REST API at some point. Will give it some testing soon. |
Fuzzbawls
reviewed
Jun 14, 2019
There was a problem hiding this comment.
Found some nits in the RPC command help texts. not a big deal, and not the only ones that have styling inconsistencies overall. Can be fixed in a separate PR that unifies all RPC command help texts.
for reference, the formatting should be
"command \"required_string_args\" required_numbool_args ( \"optional_string_args\" optional_numbool_args )\n"
|
Fixed help texts styling |
- getblockindexstats - getmintsinblocks - getserials
random-zebra
force-pushed
the
2019_getblockindexstats
branch
from
7c2c31f
to
49ef846
Compare
Fuzzbawls
added
the
Needs Release Notes
Warrows
reviewed
Jun 16, 2019
random-zebra
force-pushed
the
2019_getblockindexstats
branch
from
1598635
to
929c81b
Compare
- validaterange - getfeeinfo - geblockindexstats - getmintsinblocks - getserials
random-zebra
force-pushed
the
2019_getblockindexstats
branch
from
929c81b
to
eea9915
Compare
|
Locking strategy has been updated guarding only the access to chainActive.
|
Fuzzbawls
approved these changes
Jun 17, 2019
Warrows
approved these changes
Jun 17, 2019
Fuzzbawls
removed
Needs Release Notes
Fuzzbawls
added a commit
that referenced
this pull request
Jun 18, 2019
eea9915 [RPC] fix locking strategy (random-zebra) 49ef846 [RPC] fix help texts (random-zebra) 26b1f0c [RPC] 'getblockindexstats': count public spends separately (random-zebra) 7980f23 [RPC] fix fee calculation in 'getblockindexstats' and 'getfeeinfo' (random-zebra) 689ac23 [RPC] add 'getblockindexstats' function (random-zebra) Pull request description: This introduces a new RPC method `getblockindexstats` to get aggregated BlockIndex data for a range of blocks: - transaction count - transaction count (including coinbase/coinstake txes) - zPIV per-denom mint count - zPIV per-denom spend count - total transaction bytes - total fees in block range - average fee per kB Since it expands the functionality of `getfeeinfo`, this method has been redirected to call `getblockindexstats` (over the **last** N blocks). To avoid code duplication with `getserials` and `getmintsinblocks`, the initial validation of the input params has been refactored in the function `validaterange()`. This also contains a fix to prevent the wallet from crashing when calling these functions over out-of-range blocks. ACKs for commit eea991: Fuzzbawls: ACK eea9915 Warrows: ACK eea9915 Tree-SHA512: fd424d27b09133f8e1b646044f6e48cb7be8e7b7f6bbe51797b229e7e1c5d721226022915876d3810b38e7c2eb6bb089a7e3b8df2b0487ac251bde405e1f964a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new RPC method
getblockindexstatsto get aggregated BlockIndex data for a range of blocks:Since it expands the functionality of
getfeeinfo, this method has been redirected to callgetblockindexstats(over the last N blocks).To avoid code duplication with
getserialsandgetmintsinblocks, the initial validation of the input params has been refactored in the functionvalidaterange().This also contains a fix to prevent the wallet from crashing when calling these functions over out-of-range blocks.