Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clean and re-structure the gitian-keys directory #948

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

Fuzzbawls
Copy link
Collaborator

This changes how we present PGP keys of gitian builders by removing the
rather large pubkey files in favor of a single text file containing a
list of fingerprints and who they belong to.

The actual pubkeys are hosted on public key servers like sks-keyservers
.net.

This makes getting updates on a key much simpler as the key holder only
needs to push any updates to the key server rather than submit a new PR
here any time a key gets updated.

@Fuzzbawls Fuzzbawls added this to the 4.0.0 milestone Jul 12, 2019
@Fuzzbawls Fuzzbawls self-assigned this Jul 12, 2019
Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

This changes how we present GPG keys of gitian builders by removing the
rather large pubkey files in favor of a single text file containing a
list of fingerprints and who they belong to.

The actual pubkeys are hosted on public key servers like sks-keyservers
.net.

This makes getting updates on a key much simpler as the key holder only
needs to push any updates to the key server rather than submit a new PR
here any time a key gets updated.
@Fuzzbawls
Copy link
Collaborator Author

Rebased to include TravisCI timing fixes, and added @furszy 's key

@CaveSpectre11
Copy link

CaveSpectre11 commented Jul 26, 2019

Looks like Mrs-x should have 8AEAF0FD0F1587908F03F6B9C7435FF15397FC4E for her fingerprint.

commit e47fe3d379e826fd4cf07645f93bed5257872e0b
gpg: Signature made Tue 02 Jul 2019 02:38:12 AM EDT
gpg:                using RSA key C7435FF15397FC4E
gpg: Can't check signature: No public key
Merge: 924ec4f6d 7c9859f40
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue Jul 2 08:34:54 2019 +0200

Loading in her public key from the current release

commit e47fe3d379e826fd4cf07645f93bed5257872e0b
gpg: Signature made Tue 02 Jul 2019 02:38:12 AM EDT
gpg:                using RSA key C7435FF15397FC4E
gpg: Good signature from "Mrs-X (PIVX Development) <Mrs-X@users.noreply.github.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 8AEA F0FD 0F15 8790 8F03  F6B9 C743 5FF1 5397 FC4E
Merge: 924ec4f6d 7c9859f40
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue Jul 2 08:34:54 2019 +0200

@Fuzzbawls Fuzzbawls requested a review from Mrs-X July 28, 2019 22:56
@Fuzzbawls
Copy link
Collaborator Author

these keys are for gitian signatures only, which are not required to be the same as git commit signatures.

In the case of Mrs-X, his git commit key is not the same as his gitian signing key, which is ok because the keys.txt file here is only concerned with gitian signatures contained in the gitian.sigs Repo.

@CaveSpectre11
Copy link

In the case of Mrs-X, his git commit key is not the same as his gitian signing key, which is ok because the keys.txt file here is only concerned with gitian signatures contained in the gitian.sigs Repo.

👍 Fair enough. I guess I misunderstood when I saw the removed .gpg file had a different fingerprint than the replaced one.

@furszy furszy self-requested a review July 30, 2019 14:01
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 198a189

@Fuzzbawls Fuzzbawls merged commit 198a189 into PIVX-Project:master Aug 1, 2019
Fuzzbawls added a commit that referenced this pull request Aug 1, 2019
198a189 [Docs] Clean and re-structure the gitian-keys directory (Fuzzbawls)

Pull request description:

  This changes how we present PGP keys of gitian builders by removing the
  rather large pubkey files in favor of a single text file containing a
  list of fingerprints and who they belong to.

  The actual pubkeys are hosted on public key servers like sks-keyservers
  .net.

  This makes getting updates on a key much simpler as the key holder only
  needs to push any updates to the key server rather than submit a new PR
  here any time a key gets updated.

ACKs for top commit:
  furszy:
    utACK [198a189](198a189)

Tree-SHA512: ad110e5904e1174986b29a5dae58f96d81b11829ca35dfc8970a6f0654f6f62a2e5d0ddee4d51419a829f0a9b92d1ba9f6a373a2144277b82234e493088ef550
@random-zebra random-zebra modified the milestones: 4.0.0, 3.4.0 Aug 25, 2019
@Fuzzbawls Fuzzbawls deleted the 2019_reorg-gitian-keys branch January 9, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants