Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Fix a few compile time warnings #978

Closed

Conversation

Warrows
Copy link

@Warrows Warrows commented Aug 6, 2019

Fixes the three following warnings when compiling:

wallet/rpcdump.cpp:31:6: warning: redundant redeclaration of ‘void EnsureWalletIsUnlocked(bool)’ in same scope [-Wredundant-decls]
 void EnsureWalletIsUnlocked(bool fAllowAnonOnly);
      ^~~~~~~~~~~~~~~~~~~~~~
In file included from wallet/rpcdump.cpp:10:
./rpc/server.h:181:13: note: previous declaration of ‘void EnsureWalletIsUnlocked(bool)’
 extern void EnsureWalletIsUnlocked(bool fAllowAnonOnly = false);
             ^~~~~~~~~~~~~~~~~~~~~~
qt/privacydialog.cpp: In member function ‘void PrivacyDialog::setBalance(const CAmount&, const CAmount&, const CAmount&, const CAmount&, const CAmount&, const CAmount&, const CAmount&, const CAmount&, const CAmount&)’:
qt/privacydialog.cpp:709:13: warning: variable ‘nLockedBalance’ set but not used [-Wunused-but-set-variable]
     CAmount nLockedBalance = 0;
             ^~~~~~~~~~~~~~
warning: nonnull argument 'this' compared to NULL [-Wnonnull-compare]

@Warrows Warrows self-assigned this Aug 6, 2019
@CaveSpectre11
Copy link

utACK f6b506c

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first warning is addressed already in 955 (bad34b9).

The second is irrelevant, as 954 makes that code obsolete.

@Warrows
Copy link
Author

Warrows commented Aug 6, 2019

Right, well there is still the third one. I'll rebase on top of these PR when they are merged.

@Warrows Warrows closed this Sep 11, 2019
@Warrows Warrows deleted the 2019-08_fix-compilation-warnings branch September 11, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants