Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Remove Bitcoin Core 0.8 block hardlinking #980

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@JSKitty
Copy link

commented Aug 8, 2019

This isn't used in PIVX since none of our clients are running with Bitcoin Core's old block file structure, time to kill it?

@Warrows

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

Looks like a backport of bitcoin#9822 so conceptual ACK from my side. I'll have to verify it's indeed not used anymore (was it ever used by PIVX?) and test it before giving my final ACK.

@JSKitty

This comment has been minimized.

Copy link
Author

commented Aug 8, 2019

Didn't actually see that backport, just wandered across this via one of my fork projects. Going to add the block directory back in though, as per Bitcoin Core's commit.

src/init.cpp Outdated Show resolved Hide resolved
@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2019

Could you squash this into a single commit? pretty straight forward and yeah, no PIVX clients ever used the aforementioned data format.

@Fuzzbawls Fuzzbawls added this to In progress in Community Developer Contributions via automation Aug 9, 2019

@Fuzzbawls Fuzzbawls added this to the 4.0.0 milestone Aug 9, 2019

@JSKitty

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Squashed into a single commit.

@furszy furszy self-requested a review Aug 9, 2019

@furszy

furszy approved these changes Aug 9, 2019

Copy link
Collaborator

left a comment

Pretty straightforward cleanup 👍 , utACK c7fa318

@random-zebra
Copy link
Collaborator

left a comment

utACK c7fa318 and merging...

Community Developer Contributions automation moved this from In progress to Reviewer approved Aug 9, 2019

@random-zebra random-zebra merged commit c7fa318 into PIVX-Project:master Aug 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Community Developer Contributions automation moved this from Reviewer approved to Accepted Aug 9, 2019

random-zebra added a commit that referenced this pull request Aug 9, 2019

Merge #980: [Wallet] Remove Bitcoin Core 0.8 block hardlinking
c7fa318 Remove Bitcoin Core 0.8 block hardlinking (JSKitty)

Pull request description:

  This isn't used in PIVX since none of our clients are running with Bitcoin Core's old block file structure, time to kill it?

ACKs for top commit:
  furszy:
    Pretty straightforward cleanup 👍 ,  utACK [c7fa318](c7fa318)
  random-zebra:
    utACK c7fa318 and merging...

Tree-SHA512: 8e9fc875c6367d102685861c5ab6f02b6b634d6bfd52ba8817c776523339f0f3359cb5d2ca071ef8f6b7773ee8ac7a1fed5b5bdd7144aa66751b459facc43294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.