Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove OpenSSL 1.0 check #991

Merged

Conversation

@Warrows
Copy link
Collaborator

commented Aug 29, 2019

Up until now we've been checking for OpenSSL version at configure time. It turns out that it's not needed anymore. We still use OpenSSL in a few places, but it's not consensus critical anymore.
So this PR removes the check at configure time and cleans up a few places where includes were done of OpenSSL unnecessarily.

jonasschnelli and others added 3 commits Feb 26, 2016
[Build] Remove OpenSSL version check
Since:
- we use the lib secp256k1 instead of OpenSSL for elliptic curve related operations
- our zerocoin implementation uses gmp by default
- zerocoin is currently disabled

There is no good reason anymore to consider OpenSSL version consensus
critical. So we can remove the related configure check.
@akshaynexus

This comment has been minimized.

Copy link

commented Aug 29, 2019

Wasn't something like this done last time with openssl 1.0 and 1.1? and caused sync to not complete due to differing openssl versions?has this been tested when syncing a new node from a snapshot?with the newer openssl version.

@Warrows

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2019

I've been using OpenSSL 1.1 on all my tests and personal nodes since forever (while official builds use 1.0) and never had a problem syncing that I could have linked to that.
This check was more a precautionary measure that never had a real impact and has no reason to now.

@mmahut mmahut referenced this pull request Aug 30, 2019
4 of 10 tasks complete
@Fuzzbawls
Copy link
Collaborator

left a comment

ACK 35ec3f8

@random-zebra
Copy link
Collaborator

left a comment

ACK 35ec3f8 and merging...

random-zebra added a commit that referenced this pull request Sep 16, 2019
Merge #991: [Build] Remove OpenSSL 1.0 check
35ec3f8 [Build] Remove OpenSSL version check (warrows)
b8fb2fc [Refactor] Remove unused OpenSSL includes (warrows)
6152805 Remove openssl info from init/log and from Qt debug window (Jonas Schnelli)

Pull request description:

  Up until now we've been checking for OpenSSL version at configure time. It turns out that it's not needed anymore. We still use OpenSSL in a few places, but it's not consensus critical anymore.
  So this PR removes the check at configure time and cleans up a few places where includes were done of OpenSSL unnecessarily.

ACKs for top commit:
  Fuzzbawls:
    ACK 35ec3f8
  random-zebra:
    ACK 35ec3f8 and merging...

Tree-SHA512: e1752261b7257c3392d319bac7749c61aa17ce33705ffc41c0cec7ab21dfb11941747f37ed82e3275c90a03e76ee59e016b1983edcf648bdb30a79083bb50f04

@random-zebra random-zebra merged commit 35ec3f8 into PIVX-Project:master Sep 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Warrows Warrows deleted the Warrows:2019-09_remove-openssl1.0-check branch Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.