[Build] Remove OpenSSL 1.0 check #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since: - we use the lib secp256k1 instead of OpenSSL for elliptic curve related operations - our zerocoin implementation uses gmp by default - zerocoin is currently disabled There is no good reason anymore to consider OpenSSL version consensus critical. So we can remove the related configure check.
|
Wasn't something like this done last time with openssl 1.0 and 1.1? and caused sync to not complete due to differing openssl versions?has this been tested when syncing a new node from a snapshot?with the newer openssl version. |
|
I've been using OpenSSL 1.1 on all my tests and personal nodes since forever (while official builds use 1.0) and never had a problem syncing that I could have linked to that. |
10 tasks
Fuzzbawls
approved these changes
Sep 4, 2019
random-zebra
added a commit
that referenced
this pull request
Sep 16, 2019
35ec3f8 [Build] Remove OpenSSL version check (warrows) b8fb2fc [Refactor] Remove unused OpenSSL includes (warrows) 6152805 Remove openssl info from init/log and from Qt debug window (Jonas Schnelli) Pull request description: Up until now we've been checking for OpenSSL version at configure time. It turns out that it's not needed anymore. We still use OpenSSL in a few places, but it's not consensus critical anymore. So this PR removes the check at configure time and cleans up a few places where includes were done of OpenSSL unnecessarily. ACKs for top commit: Fuzzbawls: ACK 35ec3f8 random-zebra: ACK 35ec3f8 and merging... Tree-SHA512: e1752261b7257c3392d319bac7749c61aa17ce33705ffc41c0cec7ab21dfb11941747f37ed82e3275c90a03e76ee59e016b1983edcf648bdb30a79083bb50f04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we've been checking for OpenSSL version at configure time. It turns out that it's not needed anymore. We still use OpenSSL in a few places, but it's not consensus critical anymore.
So this PR removes the check at configure time and cleans up a few places where includes were done of OpenSSL unnecessarily.