-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus] Define SPORK_18 #995
[Consensus] Define SPORK_18 #995
Conversation
8d04dd7
to
fe79f3d
Compare
Rebased on top of #1000 |
fe79f3d
to
c408c5b
Compare
Rebased. |
449039f
to
d5b9d90
Compare
a25472f
to
913139a
Compare
fcd0600
to
4177ca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 4177ca6
rebase needed. |
#975 will generate other conflicts. |
define SPORK_18_ZEROCOIN_PUBLICSPEND_V4. When such spork is not active, zerocoin publicspend version must be 3. Otherwise must be 4.
4177ca6
to
e06f7b6
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e06f7b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e06f7b6
e06f7b6 [Tests] Minor optimizations in zerocoin_valid_public_spend test (random-zebra) cdc18ea [RPC] fix parameters check for spendzerocoin (missing ispublicspend) (random-zebra) 72bc39a [Tests] Add zerocoin_valid_public_spend to testRunner (random-zebra) 26045d3 [Consensus] Set zc PublicSpend version v3/v4 via SPORK (random-zebra) Pull request description: This follows #936 It sets the required version for zerocoin PublicSpends via SPORK instead of having it height-based. When `SPORK_18_ZEROCOIN_PUBLICSPEND_V4` is not active (default), the required version is v3 (where old version 1 serials cannot be spent. ref: #891 ). It also fixes the relative functional test `zerocoin_valid_public_spend.py` and adds it to the test_runner. ACKs for top commit: furszy: utACK e06f7b6 Warrows: utACK e06f7b6 Tree-SHA512: 07f18e77a91503f5d48dafad32364cc6292ffd1f9a3f9286a78de72dafc98b07342e6abd96eaabe55d20193f10be383c8d5bbac1b33c45712ade8c522e457b3f
This follows #936
It sets the required version for zerocoin PublicSpends via SPORK instead of having it height-based.
When
SPORK_18_ZEROCOIN_PUBLICSPEND_V4
is not active (default), the required version is v3 (where old version 1 serials cannot be spent. ref: #891 ).It also fixes the relative functional test
zerocoin_valid_public_spend.py
and adds it to the test_runner.