Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Guard MN tab from possible missing TXs in masternode.conf #998

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

Fuzzbawls
Copy link
Collaborator

In the event that masternode.conf contains invalid TXIDs, return early
instead of trying to further process, and thus avoiding a segfault.

In the event that masternode.conf contains invalid TXIDs, return early
instead of trying to further process, and thus avoiding a segfault.
@Fuzzbawls Fuzzbawls added the GUI label Sep 10, 2019
@Fuzzbawls Fuzzbawls added this to the 4.0.0 milestone Sep 10, 2019
@Fuzzbawls Fuzzbawls self-assigned this Sep 10, 2019
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4b11a00

@furszy furszy self-requested a review September 11, 2019 00:11
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4b11a00

Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

random-zebra added a commit that referenced this pull request Sep 11, 2019
….conf

4b11a00 [Qt] Guard MN tab from possible missing TXs in masternode.conf (Fuzzbawls)

Pull request description:

  In the event that masternode.conf contains invalid TXIDs, return early
  instead of trying to further process, and thus avoiding a segfault.

ACKs for top commit:
  random-zebra:
    utACK 4b11a00
  furszy:
    utACK [4b11a00](4b11a00)

Tree-SHA512: 2b69187b25805b506770cad504cf2039d8e10c9f56ba37621fa6c21c21ec838db0d51d3c10bb46db165743929d070cd1f1d6cc835d785413220b6df8bcf7b108
@random-zebra random-zebra merged commit 4b11a00 into PIVX-Project:master Sep 11, 2019
@Fuzzbawls Fuzzbawls deleted the 2019_ui-mnguard branch January 9, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants