Threshold: don't copy the entire vector just to cache the initial size. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Sep 25, 2021
furszy
added a commit
to furszy/bitcoin-core
that referenced
this pull request
Sep 25, 2021
bc64f128f0 Merge PIVX-Project/bls-signatures#10: Threshold: don't copy the entire vector just to cache the initial size. 8c75dd860d Merge PIVX-Project/bls-signatures#9: [Build] Fix autotools builds on M1 Mac CPU 46926a2216 Poly::Evaluate, don't copy the entire vector just to cache the initial vector size. 544d00ed23 [Build] Fix autotools builds on M1 Mac CPU git-subtree-dir: src/chiabls git-subtree-split: bc64f128f009fd8825f249090be9d64a74834093
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Sep 27, 2021
ad308f2 Squashed 'src/chiabls/' changes from 676ea45e80..bc64f128f0 (furszy) Pull request description: Updating the bls-sig repo to the latest version. Pulling: * PIVX-Project/bls-signatures#9 * PIVX-Project/bls-signatures#10 ACKs for top commit: random-zebra: ACK ffc8e50 Tree-SHA512: 7cc8c9b9d267e9f2de1965cf17e055c724f441a9013b0557eb897fa4029d818008a3263ebe5be97a49ff4587480885caa9d101b92b24d629c6c3203f87a032bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto-descriptive title.
The vector is being copied to a temp variable for no reason.