Fix serialization test memory leak

PJK · Apr 26, 2015 · 065ad4c · 065ad4c
1 parent df25cb5
commit 065ad4c
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/test/cbor_serialize_test.c b/test/cbor_serialize_test.c
@@ -6,6 +6,7 @@
 #include "cbor.h"
 #include "../src/cbor.h"
 #include <inttypes.h>
+#include <strings.h>
 
 
 unsigned char buffer[512];
@@ -15,27 +16,31 @@ static void test_serialize_uint8(void **state) {
 	cbor_set_uint8(item, 0);
 	assert_int_equal(1, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, (unsigned char[]){ 0x00 }, 1);
+	cbor_decref(&item);
 }
 
 static void test_serialize_uint16(void **state) {
 	cbor_item_t * item = cbor_new_int16();
 	cbor_set_uint16(item, 1000);
 	assert_int_equal(3, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x19, 0x03, 0xE8 }), 3);
+	cbor_decref(&item);
 }
 
 static void test_serialize_uint32(void **state) {
 	cbor_item_t * item = cbor_new_int32();
 	cbor_set_uint32(item, 1000000);
 	assert_int_equal(5, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x1A, 0x00, 0x0F, 0x42, 0x40 }), 5);
+	cbor_decref(&item);
 }
 
 static void test_serialize_uint64(void **state) {
 	cbor_item_t * item = cbor_new_int64();
 	cbor_set_uint64(item, 1000000000000);
 	assert_int_equal(9, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x1B, 0x00, 0x00, 0x00, 0xE8, 0xD4, 0xA5, 0x10, 0x00 }), 9);
+	cbor_decref(&item);
 }
 
 
@@ -45,6 +50,7 @@ static void test_serialize_negint8(void **state) {
 	cbor_mark_negint(item);
 	assert_int_equal(1, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, (unsigned char[]){ 0x20 }, 1);
+	cbor_decref(&item);
 }
 
 static void test_serialize_negint16(void **state) {
@@ -53,6 +59,7 @@ static void test_serialize_negint16(void **state) {
 	cbor_mark_negint(item);
 	assert_int_equal(3, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x39, 0x03, 0xE8 }), 3);
+	cbor_decref(&item);
 }
 
 static void test_serialize_negint32(void **state) {
@@ -61,6 +68,7 @@ static void test_serialize_negint32(void **state) {
 	cbor_mark_negint(item);
 	assert_int_equal(5, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x3A, 0x00, 0x0F, 0x42, 0x40 }), 5);
+	cbor_decref(&item);
 }
 
 static void test_serialize_negint64(void **state) {
@@ -69,15 +77,18 @@ static void test_serialize_negint64(void **state) {
 	cbor_mark_negint(item);
 	assert_int_equal(9, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x3B, 0x00, 0x00, 0x00, 0xE8, 0xD4, 0xA5, 0x10, 0x00 }), 9);
+	cbor_decref(&item);
 }
 
 static void test_serialize_definite_bytestring(void **state) {
 	cbor_item_t * item = cbor_new_definite_bytestring();
 	unsigned char * data = malloc(256);
+	bzero(data, 256);
 	cbor_bytestring_set_handle(item, data, 256);
 	assert_int_equal(256 + 3, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x59, 0x01, 0x00 }), 3);
 	assert_memory_equal(buffer + 3, data, 256);
+	cbor_decref(&item);
 }
 
 static void test_serialize_indefinite_bytestring(void **state) {
@@ -87,6 +98,7 @@ static void test_serialize_indefinite_bytestring(void **state) {
 	assert_int_equal(256 + 3, cbor_serialize(item, buffer, 512));
 	assert_memory_equal(buffer, ((unsigned char[]){ 0x59, 0x01, 0x00 }), 3);
 	assert_memory_equal(buffer + 3, data, 256);
+	cbor_decref(&item);
 }
 
 int main(void) {