Fix string testing todo

PJK · Dec 28, 2022 · 49f929c · 49f929c
1 parent 873c949
commit 49f929c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/cbor/strings.c b/src/cbor/strings.c
@@ -86,7 +86,6 @@ bool cbor_string_add_chunk(cbor_item_t *item, cbor_item_t *chunk) {
   struct cbor_indefinite_string_data *data =
       (struct cbor_indefinite_string_data *)item->data;
   if (data->chunk_count == data->chunk_capacity) {
-    // TODO: Add a test for this
     if (!_cbor_safe_to_multiply(CBOR_BUFFER_GROWTH, data->chunk_capacity)) {
       return false;
     }

diff --git a/test/string_test.c b/test/string_test.c
@@ -262,6 +262,24 @@ static void test_string_add_chunk(void **_CBOR_UNUSED(_state)) {
       5, MALLOC, MALLOC, MALLOC, MALLOC, REALLOC_FAIL);
 }
 
+static void test_add_chunk_reallocation_overflow(void **_CBOR_UNUSED(_state)) {
+  string = cbor_new_indefinite_string();
+  cbor_item_t *chunk = cbor_build_string("Hello!");
+  struct cbor_indefinite_string_data *metadata =
+      (struct cbor_indefinite_string_data *)string->data;
+  // Pretend we already have many chunks allocated
+  metadata->chunk_count = SIZE_MAX;
+  metadata->chunk_capacity = SIZE_MAX;
+
+  assert_false(cbor_string_add_chunk(string, chunk));
+  assert_int_equal(cbor_refcount(chunk), 1);
+
+  metadata->chunk_count = 0;
+  metadata->chunk_capacity = 0;
+  cbor_decref(&chunk);
+  cbor_decref(&string);
+}
+
 int main(void) {
   const struct CMUnitTest tests[] = {
       cmocka_unit_test(test_empty_string),
@@ -275,7 +293,7 @@ int main(void) {
       cmocka_unit_test(test_inline_creation),
       cmocka_unit_test(test_string_creation),
       cmocka_unit_test(test_string_add_chunk),
-      // TODO: string chunks realloc test
+      cmocka_unit_test(test_add_chunk_reallocation_overflow),
   };
   return cmocka_run_group_tests(tests, NULL, NULL);
 }