Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bazel-built example. #196

Merged
merged 7 commits into from
Oct 16, 2021
Merged

Add a bazel-built example. #196

merged 7 commits into from
Oct 16, 2021

Conversation

andyjgf
Copy link
Contributor

@andyjgf andyjgf commented Sep 30, 2021

PR: Add an example to the examples directory, showing how to use libcbor with Bazel

Description

Add an example to the examples directory, showing how to use libcbor with Bazel

Checklist

  • [ x] I have read followed CONTRIBUTING.md
    • [x ] I have added tests
    • [ x I have updated the documentation
    • [x ] I have updated the CHANGELOG
  • [n ] Are there any breaking changes? If so, are they documented?
  • [n ] Does this PR introduce any platform specific code? If so, is this captured in the description?
  • [n ] Security: Does this PR potentially affect security? If so, is this captured in the description?
  • [n ] Performance: Does this PR potentially affect performance? If so, is this captured in the description?

@PJK
Copy link
Owner

PJK commented Oct 6, 2021

Awesome, thank you!

Could you please take a look at the comment I left inline? Maybe I'm just missing something.
We should also add this to the CI script to make sure it doesn't get broken.

@andyjgf
Copy link
Contributor Author

andyjgf commented Oct 7, 2021

I don't see a comment, which file?
And where is the CI script?

@PJK
Copy link
Owner

PJK commented Oct 10, 2021

In examples/bazel/third_party/libcbor.BUILD, the cc_import rule is commented out

The script section of https://github.com/PJK/libcbor/blob/master/.travis.yml should basically also build the example. I can take a look at this.

@PJK PJK mentioned this pull request Oct 10, 2021
@andyjgf
Copy link
Contributor Author

andyjgf commented Oct 11, 2021 via email

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #196 (047eaee) into master (2cf83af) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   95.60%   95.48%   -0.13%     
==========================================
  Files          47       47              
  Lines        3325     3325              
  Branches      172      172              
==========================================
- Hits         3179     3175       -4     
- Misses         98      101       +3     
- Partials       48       49       +1     
Impacted Files Coverage Δ
test/fuzz_test.c 83.33% <0.00%> (-8.34%) ⬇️
src/cbor/streaming.c 97.54% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf83af...047eaee. Read the comment docs.

@PJK
Copy link
Owner

PJK commented Oct 16, 2021

This is what I meant: 72dc859

@PJK PJK self-assigned this Oct 16, 2021
@PJK PJK merged commit a1656be into PJK:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants