Updates for CMake 3, CMAKE_MODULE_PATH as subproject #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minimum required version to 3.16 (supported by most current Linux distributions). CMake 2 is no longer supported. CMAKE_MODULE_PATH set with CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR -- this enables libcbor use in an add_subdirectory context, e.g. with CMake FetchContent. subdirs is deprecated in favor of add_subdirectory.
thewtex
force-pushed
the
cmake-improvements
branch
from
4452bb5
to
de97626
Compare
|
Thanks for the PR. The change looks good, but we cannot test it on CI due to #202, so it will have to wait until I fix that. |
|
Hi @thewtex, apologies for the delay, could you please merge master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minimum required version to 3.16 (supported by most current Linux
distributions). CMake 2 is no longer supported.
CMAKE_MODULE_PATH set with CMAKE_CURRENT_SOURCE_DIR instead of
CMAKE_SOURCE_DIR -- this enables libcbor use in an add_subdirectory
context, e.g. with CMake FetchContent.
subdirs is deprecated in favor of add_subdirectory.
PR: Short description of change
Description
A clear and concise description of what the PR does and why.
Checklist