Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cbor_describe formatting and code quality #285

Merged
merged 4 commits into from Jun 3, 2023
Merged

Conversation

PJK
Copy link
Owner

@PJK PJK commented Jun 3, 2023

Follow up to #281

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #285 (aa82657) into master (1550555) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          20       20           
  Lines        1657     1665    +8     
=======================================
+ Hits         1649     1657    +8     
  Misses          8        8           
Impacted Files Coverage Δ
src/cbor.c 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PJK PJK merged commit 9ac3066 into master Jun 3, 2023
14 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 4, 2024
0.11.0 (2024-02-04)
---------------------
- [Updated documentation to refer to RFC 8949](PJK/libcbor#269)
- Improvements to `cbor_describe`
  - [Bytestring data will now be printed as well](PJK/libcbor#281) by  [akallabeth](https://github.com/akallabeth)
  - [Formatting consistency and clarity improvements](PJK/libcbor#285)
- [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286)
- BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286)
  - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead
- BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github))
  - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR`
  - This also makes decoding symmetrical with serialization, which already accepts all values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant