Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inst tab changes. Fixed bug. Upped polyphony. Added MIDI sustain support #52

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Inst tab changes. Fixed bug. Upped polyphony. Added MIDI sustain support #52

merged 4 commits into from
Dec 19, 2023

Conversation

ChrisBlueStone
Copy link
Collaborator

@ChrisBlueStone ChrisBlueStone commented Aug 19, 2023 •
edited
Loading

#51

  • Channels disabled in the tracker tab would continue to be disabled in the instruments tab and limit the number of playable notes. This issue has been fixed.
  • Increased the polyphony count from 8 to 16. (Note: computer keyboard's might be limited by the keyboard driver, but MIDI keyboards are not.)
  • Added MIDI sustain pedal support to the instruments tab.

@ChrisBlueStone ChrisBlueStone self-assigned this Aug 19, 2023
@ChrisBlueStone ChrisBlueStone changed the title Fixed disabled channels affecting instruments tab. Increased polyphony Inst tab changes. Fixed bug. Upped polyphony. Added MIDI sustain support Aug 22, 2023
PhoenixBound
PhoenixBound reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@PhoenixBound PhoenixBound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a more thorough review tomorrow and try building it, but here's what I was thinking just from reading

(I don't have a midi keyboard to test any of this with, though, heh. I'll see if the windows on-screen keyboard can help with this)

src/inst.c Outdated Show resolved Hide resolved
src/inst.c Outdated Show resolved Hide resolved
src/inst.c Outdated Show resolved Hide resolved
src/inst.c Outdated Show resolved Hide resolved
@ChrisBlueStone ChrisBlueStone merged commit 6cae590 into PKHackers:master Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoenixBound PhoenixBound Awaiting requested review from PhoenixBound

Assignees

@ChrisBlueStone ChrisBlueStone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisBlueStone @PhoenixBound