Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of cached renewal for more than 1 day #1149

Closed
barrar opened this issue Jun 17, 2019 · 2 comments
Closed

Allow use of cached renewal for more than 1 day #1149

barrar opened this issue Jun 17, 2019 · 2 comments
Milestone

Comments

@barrar
Copy link

barrar commented Jun 17, 2019

I use win-acme in a dev environment where websites are built many times per week. Every build runs win-acme to ensure SSL will work regardless of any changes that may have been made (e.g. the website was deleted and recreated or hostname changes). The bindings are reset every build by Octopus, and win-acme conveniently adds the certificate and bindings.

This is the code that is ran:
C:\win-acme.v2.0.7.315\wacs.exe --installation iis --installationsiteid $IISWebsiteID --target iissite --siteid $IISWebsiteID

With the latest build of win-acme, if the certificate has already been generated in the last 24 hours the certificate is reused. I increased this to 20 days and I no longer run into rate limits.

src/main/Services/CertificateService.cs line 170
Before: cache.CacheFile.LastWriteTime > DateTime.Now.AddDays(-1)
After cache.CacheFile.LastWriteTime > DateTime.Now.AddDays(-20)

This could be implemented as a flag or simply increased to at least a week. As seen at https://letsencrypt.org/docs/rate-limits/, the limit for renewals is 5 per week.

@WouterTinus
Copy link
Member

Good idea, won't be too difficult to make it a user setting.

@WouterTinus WouterTinus added this to the 2.0.8 milestone Jun 23, 2019
@WouterTinus
Copy link
Member

This has been released in version 2.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants