Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency improvement for KNP #47

Merged
merged 18 commits into from Apr 14, 2020

Conversation

KoichiYasuoka
Copy link
Contributor

@KoichiYasuoka KoichiYasuoka commented Apr 13, 2020

Improvement for

  • 解析格:ガ2 「象は鼻が長い」
  • 係:ト格 with 並列タイプ 「リンゴとナシとミカン」
  • 数詞 of 名詞 「三匹の子ぶた」
  • 接頭辞 「御盃を相交わす」

@KoichiYasuoka
Copy link
Contributor Author

"test extras / build (juman)" failed. Umm...

@tamuhey tamuhey self-requested a review April 14, 2020 03:17
@tamuhey
Copy link
Contributor

tamuhey commented Apr 14, 2020

Thanks for contributing!
Please add the followings as test cases in test_knp_dependency_parser

解析格:ガ2 「象は鼻が長い」
係:ト格 with 並列タイプ 「リンゴとナシとミカン」
数詞 of 名詞 「三匹の子ぶた」
接頭辞 「御盃を相交わす」

@tamuhey tamuhey added the enhancement New feature or request label Apr 14, 2020
@KoichiYasuoka
Copy link
Contributor Author

I've found that JUMAN++ mistakes ナシ for 形容詞, but not JUMAN. Well, I'll change the example to バナナ for the test.

@KoichiYasuoka
Copy link
Contributor Author

I've also found that JUMAN cuts 子ぶた into 子 and ぶた, but not JUMAN++. Umm, I'll change it for 三匹の豚.

@tamuhey
Copy link
Contributor

tamuhey commented Apr 14, 2020

Please merge origin/master into this branch for the test.

@KoichiYasuoka
Copy link
Contributor Author

I've written about this commit for conj in my diary.

@tamuhey
Copy link
Contributor

tamuhey commented Apr 14, 2020

Cool! Thank you very much!

@tamuhey tamuhey merged commit cb1fb2b into PKSHATechnology-Research:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants