Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] The cost Q-value network is repeatedly add_module #259

Closed
3 of 4 tasks
guanjiayi opened this issue Jul 29, 2023 · 2 comments
Closed
3 of 4 tasks

[Question] The cost Q-value network is repeatedly add_module #259

guanjiayi opened this issue Jul 29, 2023 · 2 comments
Labels
question Further information is requested

Comments

@guanjiayi
Copy link

guanjiayi commented Jul 29, 2023

Required prerequisites

Questions

  • The cost_critic network is repeatedly called with add_module during the creation process in the classes ConstraintActorQCritic and QCritic.

In the class of QCritic: self.add_module(f'critic_{idx}',critic)
In the class of ConstraintActorQCritic: self.add_moudle('cost_critic',self.cost_ritic)

@guanjiayi guanjiayi added the question Further information is requested label Jul 29, 2023
@Gaiejj
Copy link
Member

Gaiejj commented Jul 29, 2023

The processing here is designed to ensure that during back-propagation, propagation to corresponding parameters is guaranteed. While it does introduce some redundancy, this is a trade-off made for robustness and does not impact the correctness of the algorithm. We will consider refining the notation in subsequent updates to enhance readability.

@zmsn-2077
Copy link
Member

Feel free to ask to reopen this if you have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants