Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the author list of PIDLag #250

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

xujinming01
Copy link
Contributor

Snipaste_2023-06-23_19-54-43

@Gaiejj
Copy link
Member

Gaiejj commented Jun 23, 2023

I believe this modification is correct and necessary. However, currently, due to the updates in the ruff version, there are new requirements for code standards, and your pull request fails the lint check. We will soon open a new pull request to fix this issue. After merging the latest changes using git rebase, we will review your pull request then merge it.

@Gaiejj Gaiejj mentioned this pull request Jun 24, 2023
11 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #250 (bd3a816) into main (02376c7) will not change coverage.
The diff coverage is n/a.

❗ Current head bd3a816 differs from pull request most recent head 5856a7c. Consider uploading reports for the commit 5856a7c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         138      138           
  Lines        6994     6994           
=======================================
  Hits         6783     6783           
  Misses        211      211           
Impacted Files Coverage Δ
omnisafe/common/pid_lagrange.py 97.73% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 1a99b20 into PKU-Alignment:main Jul 1, 2023
4 checks passed
@xujinming01 xujinming01 deleted the xujinming-patch-1 branch July 3, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants