Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support isaac gym interface #325

Merged
merged 15 commits into from
May 2, 2024
Merged

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Apr 17, 2024

Description

This PR is already complete in terms of implementation accuracy. We will merge it shortly after improving the code style and documentation.

Support Safe Isaac Gym tasks in Safety-Gymnasium

Example Demo

hand.mp4

Experiment and Performance

  • ShadowHandOverSafeFinger

figure_ShadowHandOver_Safe_finger

  • ShadowHandOverSafeJoint

figure_ShadowHandOver_Safe_joint

  • ShadowHandCatchOver2UnderarmSafeFinger

figure_ShadowHandCatchOver2Underarm_Safe_finger

  • ShadowHandCatchOver2UnderarmSafeJoint

figure_ShadowHandCatchOver2Underarm_Safe_joint

Motivation and Context

Isaac Gym is a GPU-based large-scale parallel robotic simulation environment. We believe that support for the Safe Isaac Gym tasks will expand OmniSafe ’s application in robotic control safety tasks.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (3c9a235) to head (86e72d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   96.57%   96.84%   +0.27%     
==========================================
  Files         139      138       -1     
  Lines        7088     7060      -28     
==========================================
- Hits         6845     6837       -8     
+ Misses        243      223      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gaiejj Gaiejj marked this pull request as ready for review April 21, 2024 11:59
muchvo
muchvo previously approved these changes May 2, 2024
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@Gaiejj Gaiejj merged commit 924f74c into PKU-Alignment:main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants