Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crabs): refine rendering for saved crabs policies #330

Merged
merged 37 commits into from
May 6, 2024

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented May 5, 2024

Description

Refine rendering for saved CRABS policies. Now users can seamlessly render and evaluate saved CRABS policies in OmniSafe. See this file for simple usage.

Here is an example for rendering saved CRABS policy which is trained on Swing task.

eval-episode-0.mp4
Episode 0 results:
Episode reward: 22.370796449827267
Episode cost: 0.0
Episode length: 1000.0
Evaluation results:
Average episode reward: 22.370796449827267
Average episode cost: 0.0
Average episode length: 1000.0

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.05%. Comparing base (93d4975) to head (7cf39ca).

Files Patch % Lines
omnisafe/common/offline/dataset.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   96.83%   97.05%   +0.21%     
==========================================
  Files         138      137       -1     
  Lines        7071     6906     -165     
==========================================
- Hits         6847     6702     -145     
+ Misses        224      204      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit 080e6b8 into PKU-Alignment:main May 6, 2024
4 checks passed
@muchvo muchvo deleted the refine_rendering_crabs branch May 7, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants